-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vuejs demo #98
Add vuejs demo #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing the sample code. I'd be happy to merge a vueJS example, especially to document the work-around that we found on #97. However, I'd ask for a little bit of work to increase consistency with the other examples to make this more maintainable:
- Could you match the layout and style of the other example pages. To avoid coupling the example with a specific CSS framework such as Tailwind, stick with pure CSS. You can copy the stylesheet from one of the other demos.
- Could you simplify the example by removing unused files such as the various SVGs, README, etc.
- The other demos use a consistent API in the NPM scripts:
start
to run the development server andbuild
to compile the production bundle. Could you make the vueJS example also follow this approach. - Nit: rename the folder to
vuejs
.
Once these minor changes are taken care of, I'll add the integration with the build/publish pipeline so that we can get the example deployed.
Thank you! 🙌
19e6a1f
to
3d03b73
Compare
@c-w Thank you for working on this. Please confirm that the changes you requested have been made.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, I'm noting a few remaining points.
3d03b73
to
dc088b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you; I'm working on getting this integrated and will merge.
This repo is an attempt to add an example usage with vuejs using quill-vue